-
Notifications
You must be signed in to change notification settings - Fork 0
Feature rewrite parser in formal grammar #41
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to format_date_string
…initial message content
…or the "to" and "cc" keys
…ions function" This reverts commit e7e7687.
…ctions by the datetime key
… to indicate malformed header information in the reply from user section
…ctly in the reply_from_user section
…essage when the parser encounters a malformed delimiter
…ade the skipTo look for delimiters at the begining of the line
…e the skipTo look for delimiters at the begining of the line
…r and made the skipTo look for delimiters at the begining of the line
…at the start of a given line in the status, edit, and reply-to-user rules
…if a Date header is not found in a reply from user section
…e formatted in a particular way
campb303
requested changes
Aug 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall fine. Beautifully simple functions in the Item class. Some documentation changes needed. Also need to recreate __init__.py
in the top level package.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.